EQEmu / Server

Open Source Fan-Based EverQuest Emulator Server project
https://docs.eqemu.io/
GNU General Public License v3.0
441 stars 403 forks source link

[Bots] Bots in Incomplete Raid Groups Get Added Multiple Times on Zoning #3561

Open titanium-forever opened 10 months ago

titanium-forever commented 10 months ago

If bots are in incomplete raid groups, when the player zones they get duplicated in the raid group. Suspect this might be related, or similar to https://github.com/EQEmu/Server/issues/3472

Steps to reproduce:

Each time the player zones the but gets re-added until the group is full. The bot is only loaded once, it just shows multiple times in the raid group. I suspect that since bots get camped and then reloaded during the zoning process, they are getting re-added on load but they were never removed.

Only one of them can be disbanded from the raid. Once one of the names has been removed, the remaining five still show but can't be removed. Camping the bot does not remove them. Clicking on one of the names and clicking disband doesn't do anything.

image

image

Kinglykrab commented 8 months ago

Are the bot's unique identifier in bot_data and the player's unique identifier in character_data the same value?

@Aeadoin @neckkola any input?

titanium-forever commented 7 months ago

Given all the recent changes around bots, I retested this one and it seems to be fixed. I used the same bots in the same configuration as before, and for good measure I even used the same zone; the bug wasn't observed.

However, leaving this to be closed at the discretion of the project team in case there is more discussion to be had with regard to @Kinglykrab's question above.