search

EQEmu / Server

Open Source Fan-Based EverQuest Emulator Server project
https://docs.eqemu.io/
GNU General Public License v3.0
448 stars 416 forks source link

Sense Heading does not trigger EVENT_USE_SKILL #4250

Closed jdestefx closed 4 months ago

jdestefx commented 7 months ago

Would like to use this skill for a quest, but doesn't look like it's captured. Other skills I can get to spit out some debug info, but not this one.

If possible, make sure this can be captured by global_player, too.

Kinglykrab commented 4 months ago

Set the rule Skills:TrainSenseHeading to true and you will be able to use it in EVENT_USE_SKILL.

This rule is defaulted to false and due to that it does not call CheckIncreaseSkill which is required in order for EVENT_USE_SKILL to be parsed.

Setting Skills:TrainSenseHeading to true will also allow them to train their Sense Heading by using the skill.

Kinglykrab commented 4 months ago

As you can see in this code, we ignore OP_SenseHeading if that rule is set to false, meaning we never call Handle_OP_SenseHeading.

image

Kinglykrab commented 4 months ago

I added https://github.com/EQEmu/Server/pull/4424 so that you do not have to set the rule to true in order for Sense Heading to use EVENT_USE_SKILL anymore, as it should parse regardless of the rule's status.