search

EQMG / Acid

A high speed C++17 Vulkan game engine
https://equilibrium.games
MIT License
1.72k stars 154 forks source link

Run UnitTests in CI (and other improvements) #106

Closed NNemec closed 3 years ago

NNemec commented 3 years ago

Run Tests in CI. So far, only UnitTests is active, other test need to be addressed on-by-one.

Also, various fixes&improvements that came up while working on this.

mattparks commented 3 years ago

I'm a little disappointed to see the OpenAL Windows installer is an interactive installer. Because the .dll is only included for CI that will be fine and thank you for documenting the reason behind it. In the future I want to integrate more unit tests for parts of the engine like serialization, this will automate that testing.

NNemec commented 3 years ago

Indeed, I was quite disappointed myself when I found that this is the best solution I could come up with tp provide the dll.

My original in plan was to integrate the existing tests and demos to run them in CI and ensure that they at least start and finish cleanly without crashing. Currently most demos crash on startup and it is not even clear whether the problem specific to my setup or whether the code is actually broken. -- I did not get that far in one weekend. Good to see that at least this small contribution has now found its way into the main repo and will hopefully be valuable for others to build upon.