search

EQWorks / lumen-labs

React library of basic components based on Tailwind CSS
https://eqworks.github.io/lumen-labs
5 stars 2 forks source link

[G2M] textfield - fix focus, onSubmit & suffix problems #103

Closed kc-leung closed 2 years ago

kc-leung commented 2 years ago

fixes #102

github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to cce6030f966777b0e0d780fbf7a4ad0511097bef)

geoerika commented 2 years ago

@kc-leung I am trying to test this directly in widget-studio but the local build for lumen-labs I am using crashes my storybook entirely. If it's possible, can you change the package and make a pre-release on this branch for me to try out please?

kc-leung commented 2 years ago

@kc-leung I am trying to test this directly in widget-studio but the local build for lumen-labs I am using crashes my storybook entirely. If it's possible, can you change the package and make a pre-release on this branch for me to try out please?

last pre-release was in version "version": "0.1.0-alpha.27" and it is already in "version": "0.1.0-alpha.28" so there is not need to change the package version

vxsl commented 2 years ago

@kc-leung cannot give approval because my local testing in widget-studio fails. Perhaps @vxsl can do that instead.

approved :+1:

https://user-images.githubusercontent.com/53827672/154139371-27ff6c01-72cf-4021-a94a-e7854696b716.mp4

(you can't see it but I am pressing the enter button in this video lol)

geoerika commented 2 years ago

@kc-leung cannot give approval because my local testing in widget-studio fails. Perhaps @vxsl can do that instead.

approved 👍

2022-02-15.14-58-37.mp4 (you can't see it but I am pressing the enter button in this video lol)

@vxsl Is it still staying active (the border stays blue after you input a number and you move on to another button)? That was one of the features this PR should have solved... that's what I am still seeing it happens in widget-studio.

vxsl commented 2 years ago

@vxsl Is it still staying active (the border stays blue after you input a number and you move on to another button)? That was one of the features this PR should have solved... that's what I am still seeing it happens in widget-studio.

@geoerika oh, no, that seems to still be the case: image

geoerika commented 2 years ago

@kc-leung cannot give approval because my local testing in widget-studio fails. Perhaps @vxsl can do that instead.

approved 👍 2022-02-15.14-58-37.mp4 (you can't see it but I am pressing the enter button in this video lol)

@vxsl Is it still staying active (the border stays blue after you input a number and you move on to another button)? That was one of the features this PR should have solved... that's what I am still seeing it happens in widget-studio.

@vxsl The crash on pressing button was already solved in widget-studio as I added an onSubmit to handle it in TextField in MapLayerDisplay.... so, try removing those. I will try again to test this locally after dinner. Wait merging this @kc-leung until I say something.