[G2M] Dialog / Checkbox / Range-Slider - small fixes and new features

EQWorks / lumen-labs

React library of basic components based on Tailwind CSS

https://eqworks.github.io/lumen-labs

5 stars 2 forks source link

[G2M] Dialog / Checkbox / Range-Slider - small fixes and new features #108

Closed kc-leung closed 2 years ago

kc-leung commented 2 years ago

Fixed Dialog - onClick event propagation & overlay styling
Added Checkbox - check state watch useEffect for update & showlabel option
Added RangeSlider - custom tooltip & label feature

These fixes are for lumen-table updates. Let me know if it will affect any of your projects

github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to 322c2e4519eb6d84b1732da14523bcc73fe185e4)

kc-leung commented 2 years ago

I don't know how the design is, maybe @sallkall is the one to ask about his. I just think that the min label (0) should be placed with its centre aligned with the edge of the slider. This is how I designed my map legend labels as well:

Also, question, do we have a simpler slider, with just one handle?

only 2 atm but I think I can that option

kc-leung commented 2 years ago

@geoerika added single slider option. rangeSlider component will need to be refactored to be more modular it was designed as a prototypes since there were no design I only followed the old lumen-table one