search

EQWorks / lumen-labs

React library of basic components based on Tailwind CSS
https://eqworks.github.io/lumen-labs
5 stars 2 forks source link

[G2M] date-picker - add tooltip for info icon #125

Closed kc-leung closed 2 years ago

kc-leung commented 2 years ago
github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to 339563f4b0b591e4ce85d1e22155aa0e8adbecf4)

kc-leung commented 2 years ago

We need to have the icon beside the TextField label text more flexible:

1. Support custom icons, not limited to info icon (for when we want an icon other than info)

2. Be able to control the tooltip component as usual (have the ability to change variants, style just as you would when you are using the `Tooltip` component alone)

not sure if 2 is already the case but what to double check, for example be able to use tooltip without title+description or switch to the white-bg tooltip vice versa

white or dark as default for date-picker? I set it to dark cuz it makes a better contrast with the white input box but which one do you prefer? yea user can still configure the tooltip

white Screen Shot 2022-04-12 at 11 41 59 AM

sallkall commented 2 years ago

We need to have the icon beside the TextField label text more flexible:

1. Support custom icons, not limited to info icon (for when we want an icon other than info)

2. Be able to control the tooltip component as usual (have the ability to change variants, style just as you would when you are using the `Tooltip` component alone)

not sure if 2 is already the case but what to double check, for example be able to use tooltip without title+description or switch to the white-bg tooltip vice versa

white or dark as default for date-picker? I set it to dark cuz it makes a better contrast with the white input box but which one do you prefer? yea user can still configure the tooltip

white Screen Shot 2022-04-12 at 11 41 59 AM

White please :)