search

EQWorks / lumen-labs

React library of basic components based on Tailwind CSS
https://eqworks.github.io/lumen-labs
5 stars 2 forks source link

[G2M] Message #127

Closed hyx131 closed 2 years ago

hyx131 commented 2 years ago

Changes:

Screenshots:

Screen Shot 2022-04-19 at 2 06 20 PM
github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to 90a87fd862c23969d1f8d8027b15e4da6e88950b)

hyx131 commented 2 years ago

Looks good. One edge case - at high zoom levels the description/title is overflowing the container. Maybe we should also use the overflow-x/y scroll here @hyx131 image

sounds good, are we doing horizontal scroll or vertical scroll?

sallkall commented 2 years ago

Looks good. One edge case - at high zoom levels the description/title is overflowing the container. Maybe we should also use the overflow-x/y scroll here @hyx131

sounds good, are we doing horizontal scroll or vertical scroll?

Hmm I think ideally we should offer both, since you don't know if it'll be used in a fixed-width or fixed-height UI. or for the hasTitle one, use vertical, the description only one we do horizontal scroll

hyx131 commented 2 years ago

Looks good. One edge case - at high zoom levels the description/title is overflowing the container. Maybe we should also use the overflow-x/y scroll here @hyx131

sounds good, are we doing horizontal scroll or vertical scroll?

Hmm I think ideally we should offer both, since you don't know if it'll be used in a fixed-width or fixed-height UI. or for the hasTitle one, use vertical, the description only one we do horizontal scroll

added for both lol