search

EQWorks / lumen-labs

React library of basic components based on Tailwind CSS
https://eqworks.github.io/lumen-labs
5 stars 2 forks source link

[G2M] date-picker - add minDate & maxDate option #133

Closed kc-leung closed 2 years ago

kc-leung commented 2 years ago

it is a feature for the current widget studio calendar/date-picker which needs to be replaced

github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to af7bac9253a41332cf5f0a45b714a862892f5ca0)

geoerika commented 2 years ago

Extra observation:

sallkall commented 2 years ago

Extra observation:

  • I noticed that if we click on the icon in the calendar, it doesn't trigger opening the calendar. It's a it of a guessing game that we should click on theStart & End date buttons. Should we not perhaps make the icon a button as well and set it that it automatically opens & selects the start date? Not sure how good an idea is, I just feel ux can be improved here. @sallkall what do you think?

This sounds like a personal preference thing, but I do agree we should make the icon a trigger as well. Since it's still a part of the input area and clicking anywhere inside the input area should trigger the dropdown. @kc-leung can you fix this please?