search

EQWorks / lumen-labs

React library of basic components based on Tailwind CSS
https://eqworks.github.io/lumen-labs
5 stars 2 forks source link

[G2M] Icons for lumen-table replacing all material-ui/icons #136

Closed kc-leung closed 2 years ago

kc-leung commented 2 years ago

icons for https://github.com/EQWorks/lumen-table/pull/32

github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to 649118959c0232950b7527088ed9a12f358e8872)

sallkall commented 2 years ago

perhaps more of a design aspect issue (@sallkall) -- ArrowUp seems to be slightly bolder than ArrowDownRegular while they seem to be symmetrical. perhaps the implementation of one of them can be another but turning 180 degrees through styling? this way they would be theoretically highly consistent

up/down diff

up/down diff 200% (200% zoom)

perhaps more of a design aspect issue (@sallkall) -- ArrowUp seems to be slightly bolder than ArrowDownRegular while they seem to be symmetrical. perhaps the implementation of one of them can be another but turning 180 degrees through styling? this way they would be theoretically highly consistent

up/down diff

up/down diff 200% (200% zoom)

@woozyking yeah the icon naming is a bit out of control...

@kc-leung in this case maybe also update the ArrowUp icon name to ArrowUpRegular to match your new ArrowDownRegular

kc-leung commented 2 years ago

perhaps more of a design aspect issue (@sallkall) -- ArrowUp seems to be slightly bolder than ArrowDownRegular while they seem to be symmetrical. perhaps the implementation of one of them can be another but turning 180 degrees through styling? this way they would be theoretically highly consistent up/down diff up/down diff 200% (200% zoom)

perhaps more of a design aspect issue (@sallkall) -- ArrowUp seems to be slightly bolder than ArrowDownRegular while they seem to be symmetrical. perhaps the implementation of one of them can be another but turning 180 degrees through styling? this way they would be theoretically highly consistent up/down diff up/down diff 200% (200% zoom)

@woozyking yeah the icon naming is a bit out of control...

@kc-leung in this case maybe also update the ArrowUp icon name to ArrowUpRegular to match your new ArrowDownRegular

we will still need to keep it as ArrowUp if we want backward compatibility otherwise the projects that uses ArrowUp will need to update it but I think it is necessary the change

woozyking commented 2 years ago

not great for maintenance but we perhaps can temporarily export both ArrowUp and ArrowUpRegular pointing to the same icon... 😬

yea aliasing it would do for the short-term