EQWorks / lumen-labs

React library of basic components based on Tailwind CSS
https://eqworks.github.io/lumen-labs
5 stars 2 forks source link

[G2M] Radio button #161

Closed Hamaad102 closed 1 year ago

Hamaad102 commented 1 year ago

resolves #160

Changes

Horizontal

Screenshot 2023-01-11 at 12 14 41 PM

Horizontal + Left Label

Screenshot 2023-01-11 at 1 32 28 PM

Vertical

Screenshot 2023-01-11 at 12 14 31 PM

Vertical + Left Label

Screenshot 2023-01-11 at 1 32 17 PM

github-actions[bot] commented 1 year ago

📚 Storybook preview (updated to 902d6d47b7a261b9dee9cac818d99575c5d57119)

geoerika commented 1 year ago
  • lets center the label to the radio button so they are in line vertically. Also, can you add an option and sample for the label to be on the left side of the radio button?
  • remember to add forwardRef for the main/root container

Agree with KC's comments!

Hamaad102 commented 1 year ago

take a look on older component passing down {...rest} to the main container of the component for any other extra props for the div. Also, add forwardRef for radio component as well not only radioGroup

In this instance would the unique value for each radio button not serve the same purpose?

kc-leung commented 1 year ago

take a look on older component passing down {...rest} to the main container of the component for any other extra props for the div. Also, add forwardRef for radio component as well not only radioGroup

In this instance would the unique value for each radio button not serve the same purpose?

it is for the case if user only wants to use the radio component without radioGroup. For {...rest} is if user wants to add id,name,etc any other container html props