search

EQWorks / lumen-labs

React library of basic components based on Tailwind CSS
https://eqworks.github.io/lumen-labs
5 stars 2 forks source link

[G2M] Button - add custom styling #174

Closed geoerika closed 1 year ago

geoerika commented 1 year ago

https://www.notion.so/eqproduct/Lumen-Labs-Button-e4523d3a3923416f8449b09f2df2481a?pvs=4

Changes:

Button

Story

github-actions[bot] commented 1 year ago

📚 Storybook preview (updated to 6b6c7970d9bb6369fe39059047ffc894ea72b0ab)

Hamaad102 commented 1 year ago

Looks good but let's wait until @vlatawiec has a chance to look. I don't think she's had a chance to define hover effects yet for the buttons

geoerika commented 1 year ago

Looks good but let's wait until @vlatawiec has a chance to look. I don't think she's had a chance to define hover effects yet for the buttons

I don't think we need to wait for specific styling. This PR is to allow for anything to be changed, including hover.

geoerika commented 1 year ago

Looks good but let's wait until @vlatawiec has a chance to look. I don't think she's had a chance to define hover effects yet for the buttons

I don't think we need to wait for specific styling. This PR is to allow for anything to be changed, including hover.

@kc-leung what do you think? Perhaps @Hamaad102 there is a misunderstanding. We are not waiting for styling to be finalized, we are just making it possible to be able to change any styling in the lumen-labs components to whatever styling is needed to be applied.

kc-leung commented 1 year ago

Looks good but let's wait until @vlatawiec has a chance to look. I don't think she's had a chance to define hover effects yet for the buttons

I don't think we need to wait for specific styling. This PR is to allow for anything to be changed, including hover.

@kc-leung what do you think? Perhaps @Hamaad102 there is a misunderstanding. We are not waiting for styling to be finalized, we are just making it possible to be able to change any styling in the lumen-labs components to whatever styling is needed to be applied.

right, I don't think there is a need to wait for design review as long as the component is ready to be customized because we will be creating the paymi styling in the paymi web repo