[G2M] Title-Bar - Add hide header option for compact mode

EQWorks / widget-studio

Widget-creating tool for charts, maps, tables, stats

https://eqworks.github.io/widget-studio/

2 stars 3 forks source link

[G2M] Title-Bar - Add hide header option for compact mode #150

Closed kc-leung closed 2 years ago

kc-leung commented 2 years ago

fixes #147

Added arrow onHover option to hide title bar display in compact mode

@EQWorks/design-maintainers Please give me some other suggestion to make it better. This is just a temporary fix

https://user-images.githubusercontent.com/46459367/184144523-68c0cd5f-77e8-43d2-8658-55c848092b60.mov

github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to a32d2858fcfb9c4fd1f256bfe1dfb251ffadcab4)

woozyking commented 2 years ago

lint error

kc-leung commented 2 years ago

lint error

fixed

kc-leung commented 2 years ago

functionally looks good. the video shows the incorrect arrow when hidden but suppose that was taken before the second commit, though cannot verify through live storybook which is not configured to load the data. can we fix that?

true, I will upload a new video with a widget using local data so it can be tested on storybook