the propFilter was set up incorrectly before, removing one of the filters when we changed categories in ex TopCategories component, resulted in either resolution filter or the category filter not being applied.
also filtered out all filters that don't have a corresponding key in the data obj before starting to filter the data
Before:
I don't have a recording in snoke-dashboard to see both filters applied before this behaviour in WS happened, it seems fixed with the rebasing of Pei-yi's last changes in filter, as the resolution filter now is not applied to the Widget component anymore in snoke-dashboard, but goes through InsightsDataProvider
But this is how it looked:
github-actions[bot]
commented
2 years ago
Closes #165
Changes:
propFilterwas set up incorrectly before, removing one of the filters when we changed categories in ex TopCategories component, resulted in either resolution filter or the category filter not being applied.Before: I don't have a recording in snoke-dashboard to see both filters applied before this behaviour in WS happened, it seems fixed with the rebasing of Pei-yi's last changes in filter, as the resolution filter now is not applied to the Widget component anymore in snoke-dashboard, but goes through
InsightsDataProviderBut this is how it looked:After:
Recording:
https://user-images.githubusercontent.com/41120953/190431520-853e90d8-7f2f-49ed-aa02-0accdaa9e5ed.mov