EQWorks / widget-studio

Widget-creating tool for charts, maps, tables, stats
https://eqworks.github.io/widget-studio/
2 stars 3 forks source link

[G2M] Stat-Widget - Fix filter issue #190

Closed kc-leung closed 1 year ago

kc-leung commented 1 year ago

fixes #188

https://user-images.githubusercontent.com/46459367/198328432-3ac16ff4-da42-48d2-b325-be6c7f7db994.mov

github-actions[bot] commented 1 year ago

📚 Storybook preview (updated to a43e7436b84d6ae729a708a9c05b0e8a71d436d2)

kc-leung commented 1 year ago

@kc-leung The range filter seems to not work anymore in stat: Screen Shot 2022-10-28 at 12 54 37 PM

How can I recreate the issue?

https://user-images.githubusercontent.com/46459367/198693154-e777668c-b8df-46b9-9801-23783b382ed8.mov

geoerika commented 1 year ago

@kc-leung perhaps the actions did not refresh the storybook, cause that's what I tried.

geoerika commented 1 year ago

@kc-leung perhaps the actions did not refresh the storybook, cause that's what I tried.

@kc-leung perhaps the actions did not refresh the storybook, cause that's what I tried. Could you please next time check we have access to the updated storybook. Try re-run the jobs if github failed to run them.

geoerika commented 1 year ago

@kc-leung Could you please add agg for the values in this story? Download the config file for this widget with the selection & filter selected & add into the config file in the stories.

Screen Shot 2022-10-28 at 1 16 24 PM
kc-leung commented 1 year ago

@kc-leung perhaps the actions did not refresh the storybook, cause that's what I tried.

@kc-leung perhaps the actions did not refresh the storybook, cause that's what I tried. Could you please next time check we have access to the updated storybook. Try re-run the jobs if github failed to run them.

storybook is updated to the latest commit but it doesn't load the dev-stat-1 & dev-table-1 cuz it needs first order so I tested locally

kc-leung commented 1 year ago

@kc-leung Could you please add agg for the values in this story? Download the config file for this widget with the selection & filter selected & add into the config file in the stories. Screen Shot 2022-10-28 at 1 16 24 PM

yea sure will do

geoerika commented 1 year ago

I don't seem to get your version with chromatic builds. The Range filter still doesn't work. Perhaps you forgot to push some changes? Try the chromatic storybook on your side.

geoerika commented 1 year ago

@kc-leung you need to login in dev-map-2 for those 2 stories, no need to use local firstorder. It works for me. Just refresh page after login.

kc-leung commented 1 year ago

@kc-leung you need to login in dev-map-2 for those 2 stories, no need to use local firstorder. It works for me. Just refresh page after login.

true, how about the filter now? Does it work? I just tested it and it works for me