Closed vxsl closed 2 years ago
@vxsl thanks for select component restyling it, looks good.
For the ql-preview widget I thought we were limiting the number of keys to 3 max? Right now it's letting me add one for each column in the selected dataset. Do we still want to limit this and save further aggregation to the editor? I'm neutral about this just concerned about space. For large datasets we won't be able to fit them all at once in the UI.
The individual delete button looks off, the icon doesn't look centered and the hover bg color is red 😐 . Did I provide a design for this?
For the ql-preview widget I thought we were limiting the number of keys to 3 max? Right now it's letting me add one for each column in the selected dataset. Do we still want to limit this and save further aggregation to the editor? I'm neutral about this just concerned about space. For large datasets we won't be able to fit them all at once in the UI.
Ah, yes, implemented in #49! :)
The individual delete button looks off, the icon doesn't look centered and the hover bg color is red neutral_face . Did I provide a design for this?
As mentioned in a tiny footnote in this gigantic PR description:
Took a liberty on the value controls deletion buttons as I think these should still exist in some capacity -- can redesign though
So yeah, no design was provided. Looks like the vertical centering issue only occurs in Chrome (I've been developing on Firefox).
If you want to proceed with some version of these deletion buttons, let me know and I can go ahead and fix the centering. But if we're going to scrap it anyway then there's no point in fixing it hehe.
For scatterplot charts, I am not seeing the select fields for Value Key
@geoerika thanks for catching both of those. This branch has been amended to address the first error and will add fix for your second comment in #49.
improve
LinkedSelect
andPluralLinkedSelect
styling to more closely match the given designgrid
styling and programmatically setting the component width to that of the the longest possible row which is invisibly rendered.widget controls sidebar sizing has been improved in the following aspects:
WidgetControlCard
with thegrow
prop), but will not grow to match the width of any other child. The result is that the sidebar is usually the "perfect size" for the Value Keys section of the controls, but does not jump around changing width when adding keys to a multi-select as discussed in #41.20rem
and a maximum expanded width of30rem
fixed a bug where overflow scroll was showing in the widget's title bar meta details