EQWorks / widget-studio

Widget-creating tool for charts, maps, tables, stats
https://eqworks.github.io/widget-studio/
2 stars 3 forks source link

[G2M] UI/sidebar sizing #47

Closed vxsl closed 2 years ago

vxsl commented 2 years ago

image

github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to d934269d389f0101bc4fb5d926b06768bbc4bcdc)

sallkall commented 2 years ago

@vxsl thanks for select component restyling it, looks good.

For the ql-preview widget I thought we were limiting the number of keys to 3 max? Right now it's letting me add one for each column in the selected dataset. Do we still want to limit this and save further aggregation to the editor? I'm neutral about this just concerned about space. For large datasets we won't be able to fit them all at once in the UI.

image

The individual delete button looks off, the icon doesn't look centered and the hover bg color is red 😐 . Did I provide a design for this?

image

vxsl commented 2 years ago

For the ql-preview widget I thought we were limiting the number of keys to 3 max? Right now it's letting me add one for each column in the selected dataset. Do we still want to limit this and save further aggregation to the editor? I'm neutral about this just concerned about space. For large datasets we won't be able to fit them all at once in the UI.

Ah, yes, implemented in #49! :)

The individual delete button looks off, the icon doesn't look centered and the hover bg color is red neutral_face . Did I provide a design for this?

As mentioned in a tiny footnote in this gigantic PR description:

Took a liberty on the value controls deletion buttons as I think these should still exist in some capacity -- can redesign though

So yeah, no design was provided. Looks like the vertical centering issue only occurs in Chrome (I've been developing on Firefox).

If you want to proceed with some version of these deletion buttons, let me know and I can go ahead and fix the centering. But if we're going to scrap it anyway then there's no point in fixing it hehe.

geoerika commented 2 years ago

For scatterplot charts, I am not seeing the select fields for Value Key

Screen Shot 2021-11-19 at 9 44 38 AM
vxsl commented 2 years ago

@geoerika thanks for catching both of those. This branch has been amended to address the first error and will add fix for your second comment in #49.