Closed geoerika closed 2 years ago
@sallkall Agreed that the empty dropdown is problematic, but I'm not sure that showing all key options in the dropdown is a good idea. What happens in the case that you already have 4 selected value keys? Would you see 4 highlighted choices in the dropdown?
@sallkall Agreed that the empty dropdown is problematic, but I'm not sure that showing all key options in the dropdown is a good idea. What happens in the case that you already have 4 selected value keys? Would you see 4 highlighted choices in the dropdown?
yep, here's how multi-select looks in lumen labs right now:
in the original design there were even check marks beside each selected ones:
we should show it when an option(s) is selected - this is conventional in almost all UI libraries
@sallkall Ok cool sounds good, will fix in an upcoming PR. :+1:
@vxsl thanks!
@vxsl you can use the Select component guide for reference, in there you should find all the option type and states
Changes:
getLongest
toutil/index.js
to have it available for other componentsuseTransformedData
to work with map widgetnumericColumns
andstringColumns
inview/index.js
so we ave it available for widget icon buttons, as map icon is enabled only if we have coordinates got geo keys present innumericColumns
Closes #58