Reset process - selecting key value first with zero variance

[geoerika]

Problem:

• after a reset and probably when we select the first time key values in a widget, if the key column is a zero variance one and we select the key value first, the agg becomes N/A and cannot be selected, resulting in isReady being false and no chart or map is displayed.

Recording: https://user-images.githubusercontent.com/41120953/148788762-0c55e1cc-8efb-4032-9728-2c990d6bb68a.mov

[vxsl]

fixed by taking zeroVarianceColumns into consideration when computing renderableValueKeys:

  renderableValueKeys: computed(
    [
      (state) => state.valueKeys,
      (state) => state.mapValueKeys,
      (state) => state.group,
      (state) => state.type,
      (state) => state.zeroVarianceColumns,
    ],
    (
      valueKeys,
      mapValueKeys,
      group,
      type,
      zeroVarianceColumns,
    ) => (
      type === 'map'
        ? mapValueKeys.filter(({ key, agg }) => key && (agg || zeroVarianceColumns.includes(key)))
        : valueKeys.filter(({ key, agg }) => key && (agg || zeroVarianceColumns.includes(key) || !group))
    )
  ),

Perhaps you can add this to #55

[geoerika]

Did you test this? Because zeroVarianceColumns is not calculated until you use the useTransformedData which is called fromWidgetAdapter, soisReadywon't be set true in WidgetView, which calls WidgetAdapter. I believe the fix is more complex than this. I was thinking that the only way to do it would be to call useTransformData earlier (in WidgetView) and pass the data down to WidgetAdapter. I tested your solution myself and it didn't work

[vxsl]

Hmmm, that's very strange, I did test it and just double-checked, and it is working on my machine...

[geoerika]

Let me know, I can still try to include the ideas I listed here into my PR, np. I just wanted to know if you agree with it.

[geoerika]

Ok, let me try again

[vxsl]

for reference

https://user-images.githubusercontent.com/53827672/148802639-4b421d81-78d7-46cb-babe-934db47e116b.mp4

[geoerika]

Ok, just tested again, you are right, it is working. Don't know what happened when I tried it first. All good, will include this in #55.

[geoerika]

@vxsl done!

[vxsl]

:ok_hand: