Closed vxsl closed 2 years ago
This is a lumen-lab
select issue but gonna raise it here first, what overflow behaviour are you using for this multi-select component? I think right now it grows vertically infinitely, but ideally we probably want to set a max row count (3?) and then start using a vertical scroll bar within the select area.
Alternatively, we have a horizontal scroll one that I think KC already made (here's the mockup I shared with him):
Not for this PR, but maybe next. We should replace the scatterplot chart symbol as it is not a correct one. I have all chart icons in react-labs, can replace them all from there, including the correct scatterplot symbol:
Good catch, will do that in the next PR
depends on EQWorks/chart-system#156
some improvements made while preparing to overhaul the editor UI. Thought I would go ahead and publish this PR before it got too large.
So please disregard the branch name
ui/overhaul-editor
, as the actual editor UI is coming in the next one. :)store
nestedUpdate
inloadConfig
to allow nested store defaults to apply if they are not found in the configtransformedData
has been moved out ofWidgetAdapter
and into the global store (closes #67)misc
makeStyles
where possible.ValueControls
(this should have been done originally, it was an oversight)FadeBetween
, should be more performant and more predictabledev
bool was written incorrectly, now fixed (previously discussed here)main
https://user-images.githubusercontent.com/53827672/151394099-46f80b91-19e9-4a1a-b4eb-b3da0afeaa9e.mp4
simpler refactor of
CustomAccordion
https://user-images.githubusercontent.com/53827672/151395065-312bebda-fada-42ca-8a29-7275ae19d472.mp4
removed visualization resize debouncing mechanism as suggested by @geoerika in #51 (AKA no more flickering)
https://user-images.githubusercontent.com/53827672/151395506-771e818e-9d72-4a75-b794-06bad827e611.mp4
deps
added
react-color
removed
react-colorful