EQWorks / widget-studio

Widget-creating tool for charts, maps, tables, stats
https://eqworks.github.io/widget-studio/
2 stars 3 forks source link

[G2M] misc improvements #68

Closed vxsl closed 2 years ago

vxsl commented 2 years ago

depends on EQWorks/chart-system#156

some improvements made while preparing to overhaul the editor UI. Thought I would go ahead and publish this PR before it got too large.

So please disregard the branch name ui/overhaul-editor, as the actual editor UI is coming in the next one. :)


store

misc

main

https://user-images.githubusercontent.com/53827672/151394099-46f80b91-19e9-4a1a-b4eb-b3da0afeaa9e.mp4

https://user-images.githubusercontent.com/53827672/151395506-771e818e-9d72-4a75-b794-06bad827e611.mp4


deps

added

removed

github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to e0a3648a9b272df7c7a96a3ec76132beb45e1997)

sallkall commented 2 years ago

multi-select (stacked)

This is a lumen-lab select issue but gonna raise it here first, what overflow behaviour are you using for this multi-select component? I think right now it grows vertically infinitely, but ideally we probably want to set a max row count (3?) and then start using a vertical scroll bar within the select area. image

Alternatively, we have a horizontal scroll one that I think KC already made (here's the mockup I shared with him): image

vxsl commented 2 years ago

Not for this PR, but maybe next. We should replace the scatterplot chart symbol as it is not a correct one. I have all chart icons in react-labs, can replace them all from there, including the correct scatterplot symbol:

Good catch, will do that in the next PR