search

EQWorks / widget-studio

Widget-creating tool for charts, maps, tables, stats
https://eqworks.github.io/widget-studio/
2 stars 3 forks source link

[G2M] CustomButton - revert customVariant implementation #77

Closed vxsl closed 2 years ago

vxsl commented 2 years ago

had to revert the new CustomButton implementation from #73 because it was very poorly done.

Now, there's no goofy customVariant business - just use CustomButton as you would lumen-labs/Button, but be assured that sane defaults for the widget studio design will be applied. Additionally, handy props textTransform and horizontalMargin are provided. customSize was also needed because the difference between sm and md in the current LL component is not acceptable for our given design.

of course we should eventually look at some of these changes in the actual lumen-labs implementation.

added dep lodash.mergeWith, used to deep-merge the classes prop with the applied defaults

Note that there are problems with some icon colours, but these icons are being replaced soon anyway with lumen-labs equivalents that will hopefully handle the colours correctly

github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to 2302240860de9d18367cc69fb87a5713b59cfa3c)

vxsl commented 2 years ago

One bug I found that needs to be fixed in the next PRs, the DropdownSelect comp select list, when selected, is overlapped by the Filter values below:

Yep I've noticed that one too. In theory it should be addressed in lumen-labs, but it might be quicker right now to do it in widget-studio.

That being said, the design for this part is changing - so we will see if the same issue is present in the new design.