search

EQWorks / widget-studio

Widget-creating tool for charts, maps, tables, stats
https://eqworks.github.io/widget-studio/
2 stars 3 forks source link

[G2M] Add right side map editor controls / readjust Value Controls to new design for map #81

Closed geoerika closed 2 years ago

geoerika commented 2 years ago

Changes:

  1. Implemented new Map Value Configuration design

    Screen Shot 2022-02-10 at 2 09 00 PM

  2. Implemented Map Settings section:

    Screen Shot 2022-02-10 at 2 09 49 PM

  3. Rearrange styling sections for charts and organize them under Chart Settings section

    Screen Shot 2022-02-10 at 2 11 07 PM

  4. Removed map padding for Editor view

  5. Refactored the margins for Map component in adapters/react-maps

  6. Upgraded @eqworks/react-maps to v0.8.1

github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to 8f814b418a72042c01c1406323981e60d6d7a69d)

geoerika commented 2 years ago

About the customSelect shadow, it is a bit messy right now. Like I said in the QL meeting, my plan is to go over lumen-labs once WS is more complete and replace all these dropdown text-option select component with a global one.

I find the shadow one less clean than the flat one (as shown in the current design) but this is not a priority - feel free to keep this until after the beta release

Sounds good! Thanks Sally! I just wanted to be on the same page with you and Kyle on this, and Kyle mentioned in a short call he was not sure himself which way to ago about that, although he did mention that this will get more attention after the beta release. And also that lumen-labs needs a bit of a clean up.

sallkall commented 2 years ago

About the customSelect shadow, it is a bit messy right now. Like I said in the QL meeting, my plan is to go over lumen-labs once WS is more complete and replace all these dropdown text-option select component with a global one. I find the shadow one less clean than the flat one (as shown in the current design) but this is not a priority - feel free to keep this until after the beta release

Sounds good! Thanks Sally! I just wanted to be on the same page with you and Kyle on this, and Kyle mentioned in a short call he was not sure himself which way to ago about that, although he did mention that this will get more attention after the beta release. And also that lumen-labs needs a bit of a clean up.

Yeah this is totally my fault, I'll go over select/dropdown/input in detail afterwards. Will have to make do in the meantime sorry.. 🙏🏻

geoerika commented 2 years ago

looks good but I noticed that the legend and tooltip toggles don't seem to have any effect. Is this because they were moved from uniqueOptions to genericOptions?

Yes! Sorry about that! It is fixed in the last PR I am working now. Can test in that storybook: https://6139016b390968003a20da5a-gpzfwnanhe.chromatic.com/?path=/story/editor-mode--map