EQWorks / widget-studio

Widget-creating tool for charts, maps, tables, stats
https://eqworks.github.io/widget-studio/
2 stars 3 forks source link

[G2M] Integration/misc tweaks #97

Closed vxsl closed 2 years ago

vxsl commented 2 years ago

depends on EQWorks/chart-system#164


new features

UI tweaks

refactoring

bug fixes

github-actions[bot] commented 2 years ago

📚 Storybook preview (updated to f5822d80bc8a80e1d357309f567eae60260f9446)

sallkall commented 2 years ago

@vxsl can you fix the styling for this section:

Think the above fixes will do for now, we should still try to match the design in the next iteration^

vxsl commented 2 years ago

@vxsl can you fix the styling for this section:

@sallkall pushed styling fix :+1:

geoerika commented 2 years ago

Title Position control is not disabled when Title switch is off.

vxsl commented 2 years ago

Title Position control is not disabled when Title switch is off.

@geoerika good catch thank you, pushed a fix, let me know if it's better :+1:

geoerika commented 2 years ago

Question: Title Position is supposed to apply to both Title & Subplot Titles?

vxsl commented 2 years ago

Question: Title Position is supposed to apply to both Title & Subtitles?

@geoerika for now, yes. Doesn't make a ton of sense but that's how it's currently implemented in the chart-system components

geoerika commented 2 years ago

Question: Title Position is supposed to apply to both Title & Subtitles?

@geoerika for now, yes. Doesn't make a ton of sense but that's how it's currently implemented in the chart-system components

Yes, it confused me a bit.