[G2M] Controls/data source

[vxsl]

just adding the basic data source control element and some random little things tweaked leading up to last week's NPI.

basic data source selection

• added temporary DataSourceControls in lieu of complete data source controls, simply allowing the user to select from a list of executions available for the current wl/cu.
  • description is shown for each execution with some metadata - number of columns and types of columns
  • widget state resets when a new data source is selected
  • 
• added dev dependencies @eqworks/common-login and react-router-dom to facilitate an authenticated story that demonstrates this feature with actual remote fetching ("Blank Widget (data source control)")
  • for all other stories, hook useExecutions has been modified to allow data source control based on available local sample data

store

• when reloading a config, the data source is not reloaded if there is no change in data source

dashboard helpers

• new new optional props
  • editable: boolean whether "Open in editor" button should be hidden or not
  • editCallback: callback to be executed when this button is clicked, overriding default functionality

misc

• miscellaneous styling tweaks
• added a message box to display a blocking warning message:
  • 
• widget title is now saved on blurring the EditableTitle input box
• pressing Enter in the EditableTitle input box no longer causes the page to redirect
• BasicSlider goes by a step of 0.1 if max <= 1
• CustomSelect optionally accepts an array of string descriptions

deps

• react-query added as regular dependency
• @eqworks/lumen-labs updated
• @tailwindcss/forms added as dev dependency
• modified depcheck config to remove outdated ignore entries and add a new one: @tailwindcss/*
  • note: tailwind should be fully removed from this project soon.

[github-actions[bot]]

📚 Storybook preview (updated to 39d7c89f6c45120ab01d1715b79cef3a127733bf)

[vxsl]

I can't replicate the message popup you showed but by the screenclip it looks like it is just a floating white modal-like textbox? This doesn't really make sense as a UI element, would be better to use a toast instead. Though since I can't replicate this in the storybook i'm not really sure what the workflow in getting to this popup is like

I introduced this for the QL preview workflow, demo here

does it make more sense now that you see it there?

this should probably actually be taken care of inside ml-ui instead.

[sallkall]

I can't replicate the message popup you showed but by the screenclip it looks like it is just a floating white modal-like textbox? This doesn't really make sense as a UI element, would be better to use a toast instead. Though since I can't replicate this in the storybook i'm not really sure what the workflow in getting to this popup is like

I introduced this for the QL preview workflow, demo here

does it make more sense now that you see it there?

this should probably actually be taken care of inside ml-ui instead.

Ah I see why you didn't opt for a toast.

But maybe we should use the same language and style for showing this message. We have this thing below when you have no data in widget editor mode. Would be nice if we consistently used this language:

But obviously we get rid of the button and change the select data to select execution instead.

[sallkall]

I can't replicate the message popup you showed but by the screenclip it looks like it is just a floating white modal-like textbox? This doesn't really make sense as a UI element, would be better to use a toast instead. Though since I can't replicate this in the storybook i'm not really sure what the workflow in getting to this popup is like

I introduced this for the QL preview workflow, demo here does it make more sense now that you see it there? this should probably actually be taken care of inside ml-ui instead.

Ah I see why you didn't opt for a toast.

But maybe we should use the same language and style for showing this message. We have this thing below when you have no data in widget editor mode. Would be nice if we consistently used this language:

But obviously we get rid of the button and change the select data to select execution instead.

quick sketch:

see in figma: https://www.figma.com/file/DwLE8rXq7MTaVGSkoFKhJE/Widget-Studio?node-id=2109%3A31337

[vxsl]

1. I did find a set that breaks my map still (exec. 482), not sure this branch is updated, because it looks like the error we got with a few maps right before the NPI, which you fixed.

I'm not able to reproduce the error - aside from the fact that there are no eligible columns for values in that execution. Can you elaborate?

Yeah, it's weird, today it behaves differently. Yesterday I could swear I got an fsa column and another column with values and when I tried using it on the map the widget crashed . Now it's crashing from the beginning, when I try to select that execution. How does it behave on your side?

[vxsl]

Yeah, it's weird, today it behaves differently. Yesterday I could swear I got an fsa column and another column with values and when I tried using it on the map the widget crashed . Now it's crashing from the beginning, when I try to select that execution. How does it behave on your side?

@geoerika lol you edited my comment. Just checked and was able to reproduce in chrome but not firefox. Will look into it thanks for mentioning

[geoerika]

Yeah, it's weird, today it behaves differently. Yesterday I could swear I got an fsa column and another column with values and when I tried using it on the map the widget crashed . Now it's crashing from the beginning, when I try to select that execution. How does it behave on your side?

@geoerika lol you edited my comment. Just checked and was able to reproduce in chrome but not firefox. Will look into it thanks for mentioning

Oh, sorry about that!

[vxsl]

Oh, sorry about that!

@geoerika no worries :smile: -- fixed the bug, the fix was very minor so I just included it here (39d7c89).