search

EQuimper / VSC-React-Native-React-Redux-Snippets

Snippets for React and React-Native with a bit of Redux for es6/es7 user.
https://marketplace.visualstudio.com/items?itemName=EQuimper.react-native-react-redux
54 stars 31 forks source link

Create setting for semi-colon/no-semi-colon #20

Open Matheos96 opened 3 years ago

Matheos96 commented 3 years ago

Hello. Loving the plugin, one issue though. I prefer leaving out the semi colons, which I also define in my lintter. The problem of course is that this version of the plugin uses semi-colons. I know there is another version, though that one has not been updated for 3 years... I tried it out but it did not satisfy me, as this version for example always automatically fills in the name of a component from the filename, which the other version (no-semi-colons) does not. Also the snippets are not identical.

Any chance that the other version could get an update identical to this, with the exception of no semi colons? Or as the title suggests, just make a setting for it and just mantain one addon? :) Thanks

EDIT: Too be fair this is a very small tweak to do myself, I know. I just replaced all semi-colons in the snippets.json. The cry for it to be a setting is because I assume that this manual edit of mine will be undone whenever the plugin is updated.

EQuimper commented 3 years ago

@Matheos96 Umh that's a good idea. The reason why I did another package was at the time vscode didn't have a way to change that. I will search and see if I can find something. But I really like the idea

Matheos96 commented 3 years ago

:) sounds great!