Closed CJ42 closed 2 years ago
@YamenMerhi it's just a loop in the end, and use already the _setData(...)
from the internal function.
I would leave it as it is.
What would be your ideas of having:
function _setData(bytes32[] memory dataKeys, bytes[] memory dataValues) internal {
for (uint256 i = 0; i < dataKeys.length; i = _uncheckedIncrement(i)) {
_setData(dataKeys[i], dataValues[i]);
}
}
Yes something like this, it's not a big deal (just for inheritance purposes).
What does this PR introduce?
In
ERC725XCore
, move all the logic of execute function inside an internal_execute(....)
function. This will allow easier overriding of the public functionexecute(...)
for custom logic.Aside of that, removed the unnecessary
override
keyword for functions that are directly implementation of theIERC725X
andIERC725Y
interfaces.