ERC725Alliance / ERC725

Repository for code and discussion around ERC725 and related standards

Apache License 2.0

127 stars 66 forks source link

refactor: use explicit `return` statements in `ERC725XCore` #215

Closed CJ42 closed 1 year ago

CJ42 commented 1 year ago

What does this PR introduce?

♻️ Refactor

Use explicit return statements inside the internal functions of ERC725XCore, so to distinguish visually in the code what is being returned by the function.

PR Checklist

[ ] Wrote Tests (N/A)
[ ] Wrote Documentation (N/A)
[x] Ran npm run lint
[x] Ran npm run build
[x] Ran npm run test

CJ42 commented 1 year ago

@YamenMerhi we could either: Option 1: remove them completely for internal functions,

Option 2: keep them so that in the function definition, they describe what is being returned (and make the code more readable).

I am in favour of keeping them so voting for option 2.