ERC725Alliance / ERC725

Repository for code and discussion around ERC725 and related standards
Apache License 2.0
127 stars 66 forks source link

refactor!: remove deprecated constants for overloaded function selectors #219

Closed CJ42 closed 1 year ago

CJ42 commented 1 year ago

What does this PR introduce?

♻️ Refactor

Deprecate constants EXECURTE_SELECTOR, EXECUTE_BATCH_SELECTOR, SETDATA_SELECTOR and SETDATA_BATCH_SELECTOR.

Prior to v5.0.0, it was not possible to access the selector for the overloaded functions with .selector syntax in Solidity. Therefore, these selectors were saved in solidity bytes4 constant.

Since v5.0.0, overloaded functions have been removed, and it now possible to access these selectors via setData.selector and setDataBatch.selector in Solidity.

Remove these constants from the constants.sol file.

PR Checklist