search

ERC725Alliance / erc725.js

Package to interact with ERC725 smart contracts
Apache License 2.0
38 stars 29 forks source link

Add support for `Boolean` valueContent #202

Closed Hugoo closed 12 months ago

Hugoo commented 2 years ago

https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-2-ERC725YJSONSchema.md#valueContent

Add the new valueContent in this switch: https://github.com/ERC725Alliance/erc725.js/blob/develop/src/lib/encoder.ts#L144

Add tests

Hugoo commented 2 years ago

@CJ42 can you add more context for this ticket please?

Like what is the input / output for each type - as we can't see it on the specs md

Hugoo commented 2 years ago

Edit: Literal is already covered ✅

Hugoo commented 1 year ago

Will be closed in: https://github.com/ERC725Alliance/erc725.js/pull/266

CJ42 commented 12 months ago

Closing as implemented in #266