search

ERC725Alliance / erc725.js

Package to interact with ERC725 smart contracts
Apache License 2.0
38 stars 29 forks source link

Allow writing `boolean` in schema for `valueType` #268

Closed CJ42 closed 1 year ago

CJ42 commented 1 year ago

I'm submitting a...

In LSP2, the valueType for boolean values is bool because the type for true/false values in Solidity is declared as bool.

However, most user of the erc725.js library are Javascript developers. In Javascript the type is boolean.

It is also more common in plain english to use the terminology "boolean" (We say in plain english "a boolean value" ✅, not "a bool value" ❌).

Allow in erc725.js to use the word "boolean" in valueType. This should fallback by default to encoding/decoding as bool.

Hugoo commented 1 year ago

@CJ42 I think this was closed in PR: https://github.com/ERC725Alliance/erc725.js/pull/266

?

Can we close?

CJ42 commented 1 year ago

@Hugoo yes this was implemented ✅ Can be closed.