ERC725Alliance / erc725.js

Package to interact with ERC725 smart contracts
Apache License 2.0
38 stars 29 forks source link

Web3 module not found #280

Closed kalote closed 1 year ago

kalote commented 1 year ago

I'm submitting a...

Summary

When using "@erc725/erc725.js" with ethers, it doesn't work as web3 is not present in the project, and it's in the devDependencies of this repository (not included in the final package).

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Stack: NextJS 13, ethers 5.7.2, erc725 0.17.1

Step to reproduce:

./node_modules/@erc725/erc725.js/build/module/src/lib/decodeMappingKey.js:20:0
Module not found: Can't resolve 'web3'

Suggestion for fix: Make web3 module part of the package by moving it in the dependencies (PR incoming)

Hugoo commented 1 year ago

Thanks for flagging the issue! Sorry for that!

I sent a patch here: https://github.com/ERC725Alliance/erc725.js/pull/282