ERC725Alliance / erc725.js

Package to interact with ERC725 smart contracts
Apache License 2.0
38 stars 29 forks source link

feat: add `dynamicName` in schema returned by `getSchema` #428

Closed CJ42 closed 5 months ago

CJ42 commented 5 months ago

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

:star: Feature

What is the current behaviour (you can also link to an open issue here)?

400 introduced a change in the getSchema function that replaces the dynamic part <...> with the actual hex value in the name of the schema.

However, this causes a problem has the schem returned cannot be used anymore as it will the name now contains a hex value and ERC725.encodeData or ERC725.decodeData will not find the name anymore when searching through the data keys.

What is the new behaviour (if this is a feature change)?

Other information:

None

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.65%. Comparing base (9640d9f) to head (6b73a7e). Report is 192 commits behind head on develop.

Files Patch % Lines
src/lib/schemaParser.ts 93.93% 0 Missing and 2 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #428 +/- ## =========================================== - Coverage 83.71% 81.65% -2.07% =========================================== Files 18 22 +4 Lines 1130 1401 +271 Branches 255 319 +64 =========================================== + Hits 946 1144 +198 - Misses 98 150 +52 - Partials 86 107 +21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.