Closed CJ42 closed 5 months ago
Attention: Patch coverage is 94.28571%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 81.65%. Comparing base (
9640d9f
) to head (6b73a7e
). Report is 192 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
src/lib/schemaParser.ts | 93.93% | 0 Missing and 2 partials :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
:star: Feature
What is the current behaviour (you can also link to an open issue here)?
400 introduced a change in the
getSchema
function that replaces the dynamic part<...>
with the actual hex value in thename
of the schema.However, this causes a problem has the schem returned cannot be used anymore as it will the
name
now contains a hex value andERC725.encodeData
orERC725.decodeData
will not find the name anymore when searching through the data keys.What is the new behaviour (if this is a feature change)?
dynamicName
returned in the schema when dealing withMapping
andMappingWithGrouping
data keys when usinggetSchema(...)
name
of the data key to address the issue mentioned above.getSchema
function standalone, to make it available outside of class instanceOther information:
None