codecov-commenter
commented
4 weeks ago :warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.44%. Comparing base (
9640d9f) to head (3fe394d). Report is 270 commits behind head on develop.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #474 +/- ## =========================================== + Coverage 83.71% 87.44% +3.72% =========================================== Files 18 22 +4 Lines 1130 1473 +343 Branches 255 340 +85 =========================================== + Hits 946 1288 +342 - Misses 98 174 +76 + Partials 86 11 -75 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
One case where
{ verification: { method: "0x000000000" } }was still causing a problem because it was only check for method == null.What is the current behaviour (you can also link to an open issue here)?
I kept on seeing method 0x00000000 verifications failing during the indexing process.
What is the new behaviour (if this is a feature change)?
It should correctly assume those verifications to be valid.
Other information: