search

ERDDAP / erddap

ERDDAP is a scientific data server that gives users a simple, consistent way to download subsets of gridded and tabular scientific datasets in common file formats and make graphs and maps. ERDDAP is a Free and Open Source (Apache and Apache-like) Java Servlet from NOAA NMFS SWFSC Environmental Research Division (ERD).
Creative Commons Zero v1.0 Universal
76 stars 54 forks source link

Move one test into JUnit as an example #121

Closed ChrisJohnNOAA closed 7 months ago

srstsavage commented 7 months ago

Looks good! Can you comment on the approach of using src/test/WEB-INF/classes as the test dir instead of the standard src/test/java?

ChrisJohnNOAA commented 7 months ago

Awesome! I can verify that the example test passes using the expected/standard mvn clean test.

Added a couple of nits about whitespace/indenting, but 👍 to the overall approach

I accidentally added tabs (I think I've fixed my editors setting). My editor was displaying tabs as 2 spaces and GitHub was displaying as 4 (or more) spaces. Converted the offending tabs to spaces as they should have been.

ChrisJohnNOAA commented 7 months ago

Looks good! Can you comment on the approach of using src/test/WEB-INF/classes as the test dir instead of the standard src/test/java?

My thought was mirroring the directory structure of the main code. Would src/test/java/WEB-INF be a better compromise?