search

ERDDAP / erddap

ERDDAP is a scientific data server that gives users a simple, consistent way to download subsets of gridded and tabular scientific datasets in common file formats and make graphs and maps. ERDDAP is a Free and Open Source (Apache and Apache-like) Java Servlet from NOAA NMFS SWFSC Environmental Research Division (ERD).
Creative Commons Zero v1.0 Universal
76 stars 54 forks source link

Code uses emailDailyReportTo, documentation references emailDailyReportsTo #166

Open srstsavage opened 1 week ago

srstsavage commented 1 week ago

For the emailDailyReportTo setting, there is a mismatch between the EDStatic code reading setup.xml or environment variables (which references emailDailyReportTo) and the setup.xml documentation (which references emailDailyReportsTo).

EDStatic code reading emailDailyReportTo:

https://github.com/ERDDAP/erddap/blob/main/WEB-INF/classes/gov/noaa/pfel/erddap/util/EDStatic.java#L1843

Various documentation/comments referencing emailDailyReportsTo:

https://github.com/search?q=repo%3AERDDAP%2Ferddap%20emailDailyReportsTo&type=code https://github.com/ERDDAP/erddapContent/blob/main/content/erddap/setup.xml#L56 https://github.com/ERDDAP/erddapContent/blob/main/content/erddap/setup.xml#L69

These should be aligned, or EDStatic should be adjusted to accept both the singular and plural.

ChrisJohnNOAA commented 1 week ago

I think making EDStatic accept both would be the better solution.