search

ERGO-Code / HiGHS

Linear optimization software
MIT License
992 stars 184 forks source link

Fix incorrect bound checks #2040

Closed fwesselm closed 1 week ago

fwesselm commented 1 week ago

Fix incorrect signs when comparing with kHighsInf.

fwesselm commented 1 week ago

Interesting. I guess the first case doesn't matter, as rounding -inf gives -inf.

If the second was used in error, I guess it might have shown up spectacularly, but I'd have to follow through the subsequent actions properly

I can also run the entire test suite for this change, if you like. Just to see if any problem is affected...

fwesselm commented 1 week ago

Interesting. I guess the first case doesn't matter, as rounding -inf gives -inf. If the second was used in error, I guess it might have shown up spectacularly, but I'd have to follow through the subsequent actions properly

I can also run the entire test suite for this change, if you like. Just to see if any problem is affected...

I started testing and will report back tomorrow.

jajhall commented 1 week ago

Failure is due to odd behaviour for new CI test