ERNICommunity / erni-moods-android

Android ERNI moods app (Hack Sessions)
0 stars 0 forks source link

Code refactoring due to code review #39

Closed elgrangrifon45 closed 9 years ago

elgrangrifon45 commented 9 years ago

As a result of the app's code Review, the following things could be refactored:

elgrangrifon45 commented 9 years ago

Agree with the Points. Regarding bullet number 4: Why I haven't used onTabUnselected is that the SignUp and the Login don't use the ActionBar. For displaying and hiding those fragements we would have needed an other solution anyway to hide the currently displayed Fragment. That's why I decided to implement the hideFragment() method, which allows to hide the currently shown Fragment from whereever in the code you are. Does this make sens?

guslong commented 9 years ago

I think i get it now, so onTabUnselected would be useless there, you're right.

elgrangrifon45 commented 9 years ago

Closing this. Everything done, discussed or externalized ot a different issue.