ERNICommunity / erni-moods-android

Android ERNI moods app (Hack Sessions)
0 stars 0 forks source link

Factor out the String values for the fragments to an Enum #44

Closed guslong closed 9 years ago

guslong commented 9 years ago

After attempting this and making the app crash, have implemented only the first step towards the solution: Extracted the fragment tags to String constants. Only advantage I can see of having an Enum is if we have lots of fragments in the future, or to allow iterating over the fragments, which would same some code repetition in the method setupFragments. A challenge for another time...

guslong commented 9 years ago

If you are ok with this Richard, let's close it and move onto other more important things...

elgrangrifon45 commented 9 years ago

I might give it a try, since I'm preparing for OCA/OCP and I'm lacking of knowledge abou Enums. But I do agree with you that this isn't too important.