ERnsTL
commented
1 year ago - TODO handle unknown components to interrupt the network start and give back appropriate error
- DONE for counter: close the IIP port once the IIP has been delivered -> enable signaling using closure of the input -> component decides if it should keep running or if closure of input means "nothing more to do, let's finish up" -> cascades -> auto-finish of the network.
- DONE enable benchmark network from Go flowd version with 1M lines fileread -> splitlines -> count -> display.
- DONE benchmark the benchmark network from Go flowd.
- DONE detect that all components have exited (watchdog)
- DONE detect that all processes have exited
- TODO generally for components: Handling of shutting down a sub-thread in components.
- Currently, this is clumsy because the sub-thread often blocks but then wont respond to signals via a signal channel. Currently thinking about using Linux tgkill() syscall to kill component sub-threads.
- but how does mdns-sd crate responder.shutdown() handle this? it works well.
- TODO change watchdog thread to handle closed signal channels and exited components, which were used one-off to provide configuration input, for example:
- TODO change stop() to handle that some processes have already exited:
- check mqttpublisher remaining eventloop iter() thread after its main thread has shut down
- TODO handle shutdown already recognized by watchdog, but then status is still running - which should not be. And when trying to stop it, it says SendError (situation handling above when some or all processes have exited already - handling closed signal channel).
- TODO adjust stop() accordingly to handle that processes have exited (will still try to signal and join the exited threads)
- probably need to adjust runtime data struct and serde annotations
- solution: https://users.rust-lang.org/t/how-to-use-self-while-spawning-a-thread-from-method/8282/6
- TODO adjust stop() not to try signal and wait for exited threads - must be able to handle exited threads
- TODO when all components have exited, stop network right away.
- TODO enable benchmarking of runtime of the network from start (after final unpark of the threads) to stop.
- output total uptime
- cpu time used?
- TODO FBP network protocol testsuite compliance - anything left to do?
- TODO what format to use for more structured message contents? ASN.1, grpc, thrift, XML, JSON, ..?
- TODO how to allow component to select the message format it wants to use?