ES-DOC-INSTITUTIONAL / cnrm-cerfacs

CNRM-CERFACS documentation archive
https://github.com/ES-DOC-INSTITUTIONAL/cnrm-cerfacs
GNU General Public License v3.0
0 stars 1 forks source link

Strange modifications of the xlsx #7

Open mpmoine opened 5 years ago

mpmoine commented 5 years ago

@momipsl

Hi Mark,

For 2 realms (atmoschem and aerosol), I compared the last xlsx I pushed and the one updated on June 12 with the following commit:

commit f44b305df8138048e7b42354cdd48026899d2a59
Author: momipsl <momipsl@ipsl.fr>
Date:   Wed Jun 12 11:20:47 2019 +0200

    1. Initialised esm2.1 from CMIP5 documents.  2. Updated spreadsheets to latest version.

Some input values were strangely modified (cf. diff_aerosol_19-06-2019.txt and diff_atmoschem_19-06-2019.txt)

With the last realm I uploaded (land), there is no modification (cf. diff_land_20-06-2019.txt), suggesting that changes are linked to 12 June commit?

Thanks, Marie-Pierre

asladeofgreen commented 5 years ago

The input values were updated for ENUM type questions. The input values now include the enum value description from the specialisations. So after reviewing the spreadsheet I conclude that this is actually a non-issue.

mpmoine commented 5 years ago

Sorry, I don't understand what this means... What about the differences I see between the current master version of the spreadsheet and the last version I uploaded (that is prior to the master version)?

For instance, for cmip6_cnrm-cerfacs_cnrm-esm2-1_aerosol.xlsx, some input values differs (and should not) between :

mpmoine commented 4 years ago

Back on this...I think I finally understood what occurred and where the changes come from, between the xls doc I pushed and its rendering in the Es-Doc search interface.

What I understand from the ingestion process of an ENUM type entry as it works so far:

This is behavior ok when « Other » is selected. But when cell to the right are used to provide details on a particular ENUM value, then, it should append the content of the right cell to the ENUM selected value (maybe into brackets).

I understand that this kind of use of the cells on the right was not planned (only combination with "Other" was planned), but is interesting for scientists filling the doc not to restrict to values provided in an enumeration list, and can somewhere register some additional details or precisions.

mpmoine commented 4 years ago

@momipsl

When you'll have finished with the other issue, could you please have a look to this one?

Thanks :-)

mpmoine commented 4 years ago

It is really important to have "true" information in the Es-Doc search since people start using it now !

Thanks again