I added a pre-commit config pretty early in June to get some basic static code quality management in place. At the moment using pre-commit is optional (opt-in) for developers and I noticed that quite some code style issues are slipping in the repo
e.g. after running pre-commit run --all-files to fix various issue, I get these diff stats currently:
While I understand that playing pedantic code style police is not the point of this project, I still think this project plays an exemplary role in the ecosystem and we should set some bar related to code quality and give nice and consistent examples.
I think we can start with running a pre-commit check as github action to flag new issues
I added a pre-commit config pretty early in June to get some basic static code quality management in place. At the moment using pre-commit is optional (opt-in) for developers and I noticed that quite some code style issues are slipping in the repo
e.g. after running
pre-commit run --all-files
to fix various issue, I get these diff stats currently:While I understand that playing pedantic code style police is not the point of this project, I still think this project plays an exemplary role in the ecosystem and we should set some bar related to code quality and give nice and consistent examples.
I think we can start with running a pre-commit check as github action to flag new issues