search

ESA-VirES / WebClient-Framework

VirES for Swarm - web client
MIT License
3 stars 1 forks source link

Misaligned "Add filter" button #442

Closed lmar76 closed 3 years ago

lmar76 commented 3 years ago

The "Add filter" button in the Download Manager UI is misaligned:

image
pacesm commented 3 years ago

I can confirm the misaligned "Add filter" button in the current stable Chrome 89.0.4389.114. This seems like a browser-specific issue.

lmar76 commented 3 years ago

It happens also with Firefox 84.0.2

image
pacesm commented 3 years ago

Interesting. It looks okay in in my Firefox 87.0

image

In addition, the same glitch has been observed on the production instance. This does not seem like a V3.5 regression. Nevertheless, it should be investigated and fixed. Hopefully, this will required just a simple CSS layout adjustment.

pacesm commented 3 years ago

The misaligned button is cased by the negative margin: https://github.com/ESA-VirES/WebClient-Framework/blob/ecf9f3f9476772a6945cfe2f515fd09f958ea58f/app/styles/download.scss#L132 trying to compensate for the broken layout of the w2ui-field list. The offset is apparently interpreted differently in different browsers (reps. browser versions) and this "trick" is not working.

santilland commented 3 years ago

Issue should be solved with e09e62411a7a37f341672cc766bb99b49e9ca9f3 Update was deployed on staging.

lmar76 commented 3 years ago

Tested.