ESAPI / esapi-java-legacy

ESAPI (The OWASP Enterprise Security API) is a free, open source, web application security control library that makes it easier for programmers to write lower-risk applications.
https://owasp.org/www-project-enterprise-security-api/
Other
597 stars 363 forks source link

Update the logging properties to opt-out of the prefix events #844

Open mickeyz07 opened 3 weeks ago

mickeyz07 commented 3 weeks ago

I would like to disable the usage of [SECURITY SUCCESS -> /com.microservices.project.handlers.SecurityHandler]

Before the usage of ESAPI the logged line was: 2024-05-03 15:14:13,912 INFO c.t.m.e.h.SecurityHandler [pool-3-thread-1] Successfully transformed security update #1

With the ESAPI the logged line becomes: 2024-05-03 15:14:13,912 INFO [pool-3-thread-1] o.o.e.l.s.Slf4JLogLevelHandlers$3: [SECURITY SUCCESS -> /com.microservices.project.handlers.SecurityHandler] Successfully transformed security update #1

As Jeremiah J. Stacey confirmed in our email conversation, following needs to be done:

kwwall commented 3 weeks ago

You do realize that this will also affect ESAPI's internal logging, correct? Doing so may effect the alerting on any SIEM you may be using / alerting on. The one event type where I think that might make a big difference is for the EVENT_TYPE of SECURITY_AUDIT. My original intent when I added that was to add mandatory audit trails in the logs that some audit team (like at a bank) may require. It gave them a constant to lock for regardless of what the rest of the log record might be. So, this could end up disabling that and as result, break things an potentially make them non-compliant in a regulatory way.

Therefore, I think that at an absolute minimum this needs to be noted somewhere in our documentation of the property and in our the release notes. @mickeyz07 - please make a note to mention this in the ESAPI.properties file and/or in our release notes.

Just wanted you to beware. Thanks.