search

ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
4 stars 12 forks source link

Added runtime options DDT #149

Closed gold2718 closed 3 years ago

gold2718 commented 3 years ago

Moved setting of physics suite name to phys_readnl Change scripts and tests to python3 Update gen_registry and test files for metadata change from ddt_type to type Collect scheme names with call to ccpp_physics_suite_schemes Update CCPP framework external to CPF_0.2.026 Add call to cam_final in ModelFinalize

Fixes #140 Fixes #141 Fixes #144 Fixes #147 Fixes #148

gold2718 commented 3 years ago

@nusbaume, any idea why the 3.7 unit test was canceled? What does that mean? I'm not worried about the 2.7 test -- that should be removed. As for the tests failing the first time -- the lesson is to run the unit tests after the merge, not before :(

nusbaume commented 3 years ago

@goldy The python 3.7 test was canceled because there was already a failure in a different unit test (python 2.7). I have no idea why Github Actions defaults to that behavior, but I believe there is an "always" flag I can add to the workflow file to make sure that stops happening (although I will need to experiment with it some to make sure).

Also, there is already an issue discussing the need to update the python versions used by the testing system (issue #141). It might make sense to just add that modification to this PR, as it is just a one line change in this file:

.github/workflows/pr_open_sync_workflow.yml

Specifically the line:

python-version: [2.7, 3.5, 3.6, 3.7, 3.8]

Should be changed to:

python-version: [3.5, 3.6, 3.7, 3.8, 3.9]

If you push that change then I think all of your unit tests will pass, and we can close issue #141 as well. Hope that helps!

cacraigucar commented 3 years ago

@gold2718 - Since I'm not on the reviewer list, I'm assuming that you are not wanting me to review this PR.

gold2718 commented 3 years ago

@nusbaume, are you okay with the way I modified your change ideas?

gold2718 commented 3 years ago

The repository 'https://packages.microsoft.com/ubuntu/20.04/prod focal Release' is no longer signed. Error: Process completed with exit code 100.

I'm not sure we can fix this. I believe 20.04 is security update EOL which is why it is unsigned but apparently, GitHub does not have a newer version.

gold2718 commented 3 years ago

after googling around it looks like the specific version used by Github (20.04.2) should be in long-term support until 2025

I think that is true of the LTS version, I think someone at GitHub messed up the version number (at least temporarily because it seems to be working now).