search

ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
4 stars 12 forks source link

Replace "non-initialized" variable values with parameters #150

Open nusbaume opened 3 years ago

nusbaume commented 3 years ago

Currently several variables, including those that are auto-generated, are set to specific values when created to indicate that they have not been properly initialized, while still avoiding potentially random garbage values.

These values are all defined in their respective modules, but it would be better if instead they all used the same unset_XXX parameters located in the runtime_obj module. This would help clean-up the code, and provide a single location to control what these "non-initialized" values should be, at least for all of the host model routines outside of the dynamical core.

gold2718 commented 3 years ago

This can be done any time you are working on a module which sets variables to uninitialized values. Use the "addresses" GitHub tag in the PR description (at least until you are sure you've got the last one :)