search

ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
3 stars 12 forks source link

Thermo refactor #191

Closed peverwhee closed 1 year ago

peverwhee commented 1 year ago

Bringing the thermodynamics refactor of physconst into CAMDEN. Bulk changes are in separating physconst into air_composition, cam_thermo, and physconst.

Testing by running SE Kessler in both CAM and CAMDEN and dumping fields after calls to the new thermo interfaces to ensure there are no discrepancies. I am not yet done with this, but thought I'd put this out there while I'm working through the interfaces!

closes #189 closes #186

cacraigucar commented 1 year ago

Standard names are hard! I think the best we can do right now is to be consistent with our names within CAMDEN. Isn't there a list somewhere where we were going to document a "CAM variable name/CCPP Standardname" table? Perhaps we should augment this list. When we get to the point where we are going to share modules with other groups, we may need to have some discussions with the other groups and see if our standard names are equivalent with their fields or if they represent different quantities. This is definitely outside the scope of what I as a software engineer feel like I am qualified to do. I suggest it is most important right now to be consistent in CAMDEN.