search

ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
3 stars 12 forks source link

Need to add "preview_namelists" unit tests in order to test buildnml #200

Open nusbaume opened 1 year ago

nusbaume commented 1 year ago

Currently there are no unit tests for buildnml in the automated testing framework, nor are there any integration tests for the complete model configuration/code generation/namelist generation system.

To resolve this issue, it would be beneficial to create some tests where the model is setup all the way through the preview_namelists step, and then the resulting generated files are checked to make sure they match what is expected.

Also, given that all of this will theoretically go through only the python code, the tests should be easily runnable in a Github Actions workflow. This workflow can also be designed such that it only runs if the standard python unit tests workflow passes successfully.

nusbaume commented 9 months ago

This type of unit test would also be able to test the fixes for issues #239 and #240 , and ensure that these particular problems don't show up again.