ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
3 stars 12 forks source link

Set thermodynamically active species from constituents object #207

Closed nusbaume closed 1 year ago

nusbaume commented 1 year ago

What is the feature/what would you like to discuss?

Currently the number of thermodynamically active species is set via namelist entries in air_composition, which internally contains the list of all possible species via a "case-select" code section. However, the namelist values are set to default to the total number of water species provided by the physics, and discussions with scientists (e.g. @PeterHjortLauritzen) implied that there was no real scientific reason to not always use the total number of species provided by the physics.

Given this, instead of having the species be a namelist option, a better choice might be to simply maintain the case-select statement, and then loop over all of the constituents that exist in the constituents object/array. This will reduce the total code amount, and avoid an additional step where errors could possibly occur.

Is there anyone in particular you want to be part of this conversation?

@peverwhee

Will this change (regression test) answers?

No

Will you be implementing this enhancement yourself?

Any Software Engineer can do this