search

ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
3 stars 12 forks source link

Required variable standard name updates #210

Closed nusbaume closed 10 months ago

nusbaume commented 1 year ago

What happened?

After going through the CAM names with scientists, the following standard names need to be updated:

  1. reference_pressure_at_surface -> reference_pressure
  2. reference_pressure -> reference_pressure_of_atmosphere_layer (need to check with NOAA first)
  3. reference_pressure_normalized_by_surface_pressure -> reference_pressure_of_atmosphere_layer_normalized_by_surface_pressure (need to check with NOAA first)
  4. rain_water_mixing_ratio_wrt_moist_air -> rain_mixing_ratio_wrt_moist_air
  5. rain_water_mixing_ratio_wrt_dry_air -> rain_mixing_ratio_wrt_dry_air
  6. snow_water_mixing_ratio_wrt_moist_air -> snow_mixing_ratio_wrt_moist_air
  7. ln_of_air_pressure -> ln_air_pressure
  8. ln_of_air_pressure_at_interface -> ln_air_pressure_at_interface
  9. ln_of_air_pressure_of_dry_air -> ln_air_pressure_of_dry_air
  10. ln_of_air_pressure_of_dry_air_at_interface -> ln_air_pressure_of_dry_air_at_interface
  11. pressure_thickness -> air_pressure_thickness
  12. pressure_thickness_of_dry_air -> air_pressure_thickness_of_dry_air
  13. geopotential_at_surface -> surface_geopotential
  14. reciprocal_of_pressure_thickness -> reciprocal_of_air_pressure_thickness
  15. reciprocal_of_pressure_thickness_of_dry_air -> reciprocal_of_air_pressure_thickness_of_dry_air
  16. x_wind -> eastward_wind
  17. y_wind -> northward_wind
  18. geopotential_height -> geopotential_height_wrt_surface
  19. geopotential_height_at_interface -> geopotential_height_wrt_surface_at_interface
  20. tendency_of_x_wind_due_to_model_physics -> tendency_of_eastward_wind_due_to_model_physics
  21. tendency_of_y_wind_due_to_model_physics -> tendency_of_northward_wind_due_to_model_physics
  22. column_integrated_total_kinetic_and_static_energy_of_current_state -> vertically_integrated_energies_of_current_state_in_cam
  23. column_integrated_total_kinetic_and_static_energy_of_initial_state -> vertically_integrated_energies_of_initial_state_in_cam
  24. column_integrated_total_water_of_current_state -> vertically_integrated_total_water_of_current_state
  25. column_integrated_total_water_of_initial_state -> vertically_integrated_total_water_of_initial_state

Along with these changes, it was noticed that in src/dynamics/utils/hycoef.F90 that the psr and ps0 variables are always set to match each other, and thus there is no reason to maintain both quantities.

What are the steps to reproduce the bug?

Start talking to scientists

What CAMDEN hash were you using?

101fd31

What machine were you running CAMDEN on?

Other (please explain below)

What compiler were you using?

Other (please specify below)

Path to a case directory, if applicable

No response

Will you be addressing this bug yourself?

Yes

Extra info

This is a "bug" from a science standpoint, not a software standpoint. Hence there isn't any particular run that this bug is associated with.

nusbaume commented 1 year ago

Adding a note here that specific_humidity now needs to be renamed to water_vapor_mixing_ratio_wrt_moist_air_and_condensed_water.