ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
3 stars 12 forks source link

Over-allocating active species arrays in air_composition.F90 #213

Open peverwhee opened 1 year ago

peverwhee commented 1 year ago

Issue Type

Code Clean-up

Issue Description

In air_composition_init (air_composition.F90), we are allocating the thermodynamic_activespecies* arrays to num_advected, which, in the long term, may be far larger than it needs to be.

The code in CAM was allocating these to dry_air_species + water_air_species, which were determined by the NL. The NL entries have been removed, so we will need a new way to allocate these arrays in a more efficient manner.

Will this change answers?

None

Will you be implementing this yourself?

Any Software Engineer can do this