search

ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
3 stars 12 forks source link

Initial attempt of setting default constituent value. #226

Closed mwaxmonsky closed 1 year ago

mwaxmonsky commented 1 year ago

New implementation will attept to find constituent value from file, otherwise will default to value declared in meta files, otherwise 0.

mwaxmonsky commented 1 year ago

Good call on both changes! Updated.

nusbaume commented 1 year ago

@peverwhee @cacraigucar It looks like I'll need these changes as well in order to properly validate the physics schemes in atmospheric_physics. So if you could bump this review up somewhat in terms of your priorities that would be great, thanks!

mwaxmonsky commented 1 year ago

@cacraigucar I updated the error message formatting on this last commit, could you take a look at the implementation and just let me know if it seems reasonable? Just want to make sure the way I'm using the string concatenation is consistent.