search

ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
3 stars 11 forks source link

Have physics scheme tests check for compiler warnings #234

Open nusbaume opened 9 months ago

nusbaume commented 9 months ago

What is the feature/what would you like to discuss?

It is oftentimes quite easy for compiler warnings to go unnoticed, even though they can reveal bugs that can cause real problems later.

To try and avoid that scenario, it would be great if all compiler warning messages were fixed for CAM-SIMA when using the FPHYStest compset and the relevant physics suites or schemes. Then when physics schemes are tested using the framework described in issue #230, a -Werror flag can be added to the GNU compiler calls that convert all compiler warnings to errors (which will result in a test failure if a warning appears). This way we can ensure that the CCPP-ized physics schemes generate no warnings, and have a mechanism that will quickly notify developers if new warnings show up in the future.

Is there anyone in particular you want to be part of this conversation?

No response

Will this change (regression test) answers?

I Don't Know

Will you be implementing this enhancement yourself?

Any Software Engineer can do this

nusbaume commented 8 months ago

Adding a note here that it might be good to make sure these tests use the -check all compiler flag, at least for the CCPP-ized physics schemes themselves, as this will help ensure that the physics is compliant with NOAA's operational model standards, as described in the latest standards document found here:

https://www.nco.ncep.noaa.gov/idsb/implementation_standards/